Handle non-ASCII chars correctly #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per pndurette#21 non ASCII chars were not correctly being calculated. This due to an error in the calculate_token function. The diff should be self explanatory when comparing it with the token-script.js. I added a couple of tests to make sure all unicode chars are correctly being calculated.
|
Any suggestions as to properly handle both Python 2.7 and 3.x unicode string handling without too much ado? (Besides dropping support for Python 3.2?) |
As it turns out a lot of the token-script was just doing the utf-8 encoding of a piece of text. Python can also do that, so now it's way simpler.
|
Otherwise there is six.text_type, but that would introduce a new dependency. |
|
From what I read, dropping Python 3.2 is the thing to do and what most projects are doing. So I guess we can agree on this. Thanks a lot for this (fast) fix @Boudewijn26! Will release this shortly. |
pndurette
added a commit
that referenced
this pull request
Jan 24, 2016
Handle non-ASCII chars correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #21 tokens aren't correctly calculated when they contain non-ASCII chars. I found and fixed the bug, as well as adding a couple extra tests.