From 94873eb1012b0097e4afc334081dce58d12eb0e2 Mon Sep 17 00:00:00 2001 From: Xavier Mouligneau Date: Thu, 17 Mar 2022 14:59:45 -0400 Subject: [PATCH] mike feedback for X --- .../alerting/server/rules_client/rules_client.ts | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/x-pack/plugins/alerting/server/rules_client/rules_client.ts b/x-pack/plugins/alerting/server/rules_client/rules_client.ts index 9ca52fcf799783..eca8c2e18fb46e 100644 --- a/x-pack/plugins/alerting/server/rules_client/rules_client.ts +++ b/x-pack/plugins/alerting/server/rules_client/rules_client.ts @@ -1493,6 +1493,12 @@ export class RulesClient { id: string; snoozeEndTime: string | -1; }): Promise { + if (typeof snoozeEndTime === 'string') { + const snoozeDateValidationMsg = validateSnoozeDate(snoozeEndTime); + if (snoozeDateValidationMsg) { + throw new RuleMutedError(snoozeDateValidationMsg); + } + } return await retryIfConflicts( this.logger, `rulesClient.snooze('${id}', ${snoozeEndTime})`, @@ -1501,13 +1507,6 @@ export class RulesClient { } private async snoozeWithOCC({ id, snoozeEndTime }: { id: string; snoozeEndTime: string | -1 }) { - if (typeof snoozeEndTime === 'string') { - const snoozeDateValidationMsg = validateSnoozeDate(snoozeEndTime); - if (snoozeDateValidationMsg) { - throw new RuleMutedError(snoozeDateValidationMsg); - } - } - const { attributes, version } = await this.unsecuredSavedObjectsClient.get( 'alert', id