feat: use-sync-external-store #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1be05d1:
|
|
Four tests failed:
I feel like we should hit v4 major with breaking changes. |
|
I hacked around, but not sure if this causes a problem with cases where we used to have zombie children. |
timkindberg
reviewed
Sep 28, 2021
tests/basic.test.tsx
Outdated
| @@ -150,7 +150,9 @@ it('re-renders with useLayoutEffect', async () => { | |||
|
|
|||
| const container = document.createElement('div') | |||
| ReactDOM.render(<Component />, container) | |||
| expect(container.innerHTML).toBe('true') | |||
| waitFor(() => { | |||
There was a problem hiding this comment.
I believe you need an await in front?
There was a problem hiding this comment.
Oh, nice catch. I hope it works with await.
|
Size Change: -2.58 kB (-8%) ✅ Total Size: 30 kB
ℹ️ View Unchanged
|
This was referenced Dec 21, 2021
Closed
|
@dai-shi I noticed that you removed the Is not needed anymore? |
|
@phaistonian Yes. Please see #971. |
No, I don't think so. |
1 task
dai-shi
pushed a commit
that referenced
this pull request
Mar 22, 2023
As per the discussions below, memoizing selectors does not improve performance significantly as of v4. Thus we should avoid recommending selector memoization. Note that the same paragraph was removed from the README in PR #550 (#550) and this section may have been left behind as an oversight. - #658 - #971
Mercury21th000
pushed a commit
to Mercury21th000/zustand
that referenced
this pull request
Nov 17, 2024
As per the discussions below, memoizing selectors does not improve performance significantly as of v4. Thus we should avoid recommending selector memoization. Note that the same paragraph was removed from the README in PR #550 (pmndrs/zustand#550) and this section may have been left behind as an oversight. - pmndrs/zustand#658 - pmndrs/zustand#971
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No public API changes
The API is compatible with the latest v3 API
Major changes
Better support for context usage
useStorehook.createStorefromzustand/vanillazustand/contextis fully rewritten with the newuseStore.