Bottleneck on large objects

[joelbqz]

Hello @dai-shi I made an experiment of having 5000 form fields with different state managers and found out that Valtio isn't performing well:

Jotai
https://codesandbox.io/s/form-test-jotai-05chcf?file=/src/App.tsx

Zustand
https://codesandbox.io/s/form-test-zustand-u53m0s

Valtio(increase SIZE to 5000)
https://codesandbox.io/s/form-test-valtio-b61ldg

[dai-shi]

Thanks for reporting!
There seems nothing wrong in the usage. Something must be wrong on the library end.
(A bit surprising that nobody has reported this in the past. 😅 )

[dai-shi]

Looks like createProxyToCompare is slow.

valtio/src/react.ts

Line 156 in 7c85c14

return createProxyToCompare(currSnapshot, currAffected, proxyCache)

And, it probably happens with valtio only (not with react-tracked) because valtio snapshot is always frozen.

[dai-shi]

Fixed! https://codesandbox.io/s/form-test-valtio-fgz47b

[joelbqz]

that was fast ⚡ Great work

[dai-shi]

This issue is back again in v1.10.1 by #656.