Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OrbitControls.zoomToCursor missing #285

Closed
alessiocancian opened this issue Sep 13, 2023 · 1 comment · Fixed by #286
Closed

OrbitControls.zoomToCursor missing #285

alessiocancian opened this issue Sep 13, 2023 · 1 comment · Fixed by #286
Labels
enhancement New feature or request

Comments

@alessiocancian
Copy link

  • three version: 0.156.1
  • @types/three version: 0.156.0
  • three-stdlib version: 2.51.1

Problem description:

Three.js documentation mentions a zoomToCursor prop for OrbitControls but I can't use it with @react-three/drei because three-stdlib's OrbitControls doesn't support it.
https://threejs.org/docs/?q=zoomToCursor#examples/en/controls/OrbitControls.zoomToCursor

Suggested solution:

Update OrbitControls on three-stdlib.
@alessiocancian alessiocancian added the bug Something isn't working label Sep 13, 2023
@CodyJasonBennett CodyJasonBennett added enhancement New feature or request and removed bug Something isn't working labels Sep 13, 2023
@CodyJasonBennett
Copy link
Member

mrdoob/three.js#26165, mrdoob/three.js#26549

@CodyJasonBennett CodyJasonBennett mentioned this issue Sep 13, 2023
Merged
@CodyJasonBennett CodyJasonBennett linked a pull request Sep 13, 2023 that will close this issue
feat(OrbitControls): zoomToCursor #286
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(OrbitControls): zoomToCursor pmndrs/three-stdlib
2 participants
@alessiocancian @CodyJasonBennett