Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support inverting horizontal / vertical orbit direction separately in OrbitControls #279

Closed
boweihan opened this issue Aug 23, 2023 · 0 comments · Fixed by #280
Closed

Support inverting horizontal / vertical orbit direction separately in OrbitControls #279

boweihan opened this issue Aug 23, 2023 · 0 comments · Fixed by #280
Labels
enhancement New feature or request

Comments

@boweihan
Copy link
Contributor

boweihan commented Aug 23, 2023 •
edited
Loading

Describe the feature you'd like:

I'm trying to support drag controls that are different from what OrbitControls ships out of the box. The horizontal drag behaviour is what I want, but the vertical is inverted. Currently, we only have reverseOrbit, which enables the vertical drag behaviour that I want but inverts the horizontal as well.

Suggested implementation:

reverseHorizontalOrbit as a new API that enables inverting just the horizontal orbit direction.
reverseVerticalOrbit as a new API that enables inverting just the vertical orbit direction.

#280
@boweihan boweihan added the enhancement New feature or request label Aug 23, 2023
@CodyJasonBennett CodyJasonBennett linked a pull request Aug 23, 2023 that will close this issue
feat(OrbitControls): reverse horizontal and vertical orbits separately #280
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(OrbitControls): reverse horizontal and vertical orbits separately boweihan/three-stdlib
1 participant
@boweihan