Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: react 18 #330

Closed
wants to merge 4 commits into from
Closed

feat: react 18 #330

wants to merge 4 commits into from

Conversation

gsimone
Copy link
Member

@gsimone gsimone commented Apr 26, 2022 •
edited
Loading

Depends on

TODO

  • Use zustand 4 release candidate

@vercel
Copy link

vercel bot commented Apr 26, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
leva ✅ Ready (Inspect) Visit Preview May 5, 2022 at 3:10PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: f15f2ba

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gsimone gsimone changed the base branch from main to feat/pnpm April 26, 2022 17:43
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 26, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f15f2ba:

Sandbox Source
leva-minimal Configuration
leva-busy Configuration
pmndrs/leva Configuration
leva-advanced-panels Configuration
pmndrs/leva Configuration
leva-theme Configuration
leva-transient Configuration
leva-plugin-plot Configuration
leva-plugin-bezier Configuration
leva-plugin-spring Configuration
leva-custom-plugin Configuration

alexandernanberg
alexandernanberg reviewed May 14, 2022
View reviewed changes
packages/leva/src/components/Leva/Leva.tsx
Comment on lines +43 to +44
const root = createRoot(rootEl)
root.render(<Leva isRoot />)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I saw somewhere that using multiple roots is discouraged in React 18, would it be possible to switch to createPortal() instead? I guess the API might have to change, e.g. requiring consumers to render a <Leva /> component

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would actually be good API change where there's less "magic" and you can easily toggle it on and off.

@js2702
Copy link

js2702 commented Jun 20, 2022

Any update on this?

@apecollector apecollector mentioned this pull request Sep 7, 2022
Closed
@chrislicodes
Copy link

Any update on this?

@CodyJasonBennett CodyJasonBennett mentioned this pull request Oct 28, 2022
Merged
@dbismut
Copy link
Collaborator

dbismut commented Nov 27, 2022

Closing in favor of #412

@dbismut dbismut closed this Nov 27, 2022
disambiguator added a commit to disambiguator/floating_points that referenced this pull request Dec 22, 2022
@disambiguator
Upgrade
aee1a6e 
Everything is mostly working but:
 - Leva is weirdly small. Waiting until they get things working on R18 here.
   pmndrs/leva#330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apecollector apecollector apecollector left review comments

@alexandernanberg alexandernanberg alexandernanberg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gsimone @js2702 @chrislicodes @dbismut @alexandernanberg @apecollector