Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix pnpm setup #2646

Merged
merged 3 commits into from
Jul 9, 2024
Merged

ci: fix pnpm setup #2646

merged 3 commits into from
Jul 9, 2024

Conversation

himself65
Copy link
Collaborator

@vercel Vercel
Copy link

vercel bot commented Jul 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 10:52pm

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jul 3, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

LiveCodes Preview in LiveCodes

Latest commit: 8f71ff9
Last updated: Jul 8, 2024 10:51pm (UTC)

Playground Link
React demo https://livecodes.io?x=id/AMD33TZVW

See documentations for usage instructions.

@himself65 himself65 requested a review from dai-shi July 3, 2024 19:12
@dai-shi
Copy link
Member

dai-shi commented Jul 3, 2024 •
edited
Loading

Can you send the same PR to zustand and valtio too?

(...and we have to do this to all jotaijs/*, zustandjs/*, valtiojs/* 😱 )

dai-shi
dai-shi reviewed Jul 4, 2024
View reviewed changes
.github/workflows/compressed-size-action.yml Outdated
@@ -9,9 +9,7 @@ jobs:

steps:
- uses: actions/checkout@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to v4 like you did in waku? (so sorry, I should have checked this before asking for zustand&valtio.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we can

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do that then. can you update all three prs?

This was referenced Jul 4, 2024
Merged
Merged
@dai-shi
Copy link
Member

dai-shi commented Jul 4, 2024 •
edited
Loading

(...and we have to do this to all jotaijs/*, zustandjs/*, valtiojs/* 😱 )

I'm writing a bash script to change all my local repos. 😁

@dai-shi
Copy link
Member

dai-shi commented Jul 8, 2024

#2646 (comment)

@himself65 a reminder.

@himself65
Copy link
Collaborator Author

finished

dai-shi
dai-shi approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@dai-shi dai-shi merged commit 4db874c into pmndrs:main Jul 9, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-shi dai-shi dai-shi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himself65 @dai-shi