Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to Latest ThreeJS adds an extra plane like geometry #2015

Open
sabinayakc opened this issue Jul 1, 2024 · 4 comments
Open

Upgrading to Latest ThreeJS adds an extra plane like geometry #2015

sabinayakc opened this issue Jul 1, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@sabinayakc
Copy link

 "@react-three/drei": "9.108.1",
    "@react-three/fiber": "8.16.8",
    "@types/three": "0.166.0",
    "react": "18.2.0",
    "react-dom": "18.2.0",
    "react-scripts": "5.0.1",
    "three": "0.166.0"

Problem description:

I upgraded to the latest three and I see a weird plane geometry. It happens in other cases as well.
image

Relevant code: Update this codesandbox to the latest versions.

https://codesandbox.io/s/57iefg

@sabinayakc sabinayakc added the bug Something isn't working label Jul 1, 2024
@rndexe
Copy link

rndexe commented Aug 3, 2024

I'm assuming this is using <AccumulativeShadows>.

Steps to fix:

  1. Multiply intensity of RandomizedLight by Math.PI if set to 1
  2. Reduce alphaTest on AccumulativeShadows just enough that the plane disappears

@sabinayakc
Copy link
Author

sabinayakc commented Sep 12, 2024

Im using helper. How do I fix this ?

 <Stage
        intensity={1}
        preset="rembrandt"
        shadows={{
          type: 'accumulative',
          color: 'skyblue',
          colorBlend: 2,
          opacity: 1
        }}
        adjustCamera={1}
        environment="city"
      >
      ```

@rndexe
Copy link

rndexe commented Sep 12, 2024

try adding intensity: Math.PI to the shadows prop. Like so :

 <Stage
        intensity={1}
        preset="rembrandt"
        shadows={{
          type: 'accumulative',
          color: 'skyblue',
          colorBlend: 2,
          opacity: 1,
          intensity: Math.PI
        }}
        adjustCamera={1}
        environment="city"
      >    

@github-actions github-actions bot added the Stale Inactive issue label Nov 11, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2024
@CodyJasonBennett CodyJasonBennett removed the Stale Inactive issue label Nov 18, 2024
@pmndrs pmndrs deleted a comment from github-actions bot Nov 18, 2024
@pmndrs pmndrs deleted a comment from github-actions bot Nov 18, 2024
@calvinhnzr
Copy link

The plane starts to appear from three.js version r155 and higher. From r154 and below the plane is not visible.

Grid Component r154
Grid Component r155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants