Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore Edge component to accept geometry as prop #1978

Conversation

nickthegroot
Copy link
Contributor

Why

fixes #1893

A previous refactor of the <Edges> component made it so that passing geometry as a prop no longer worked. This is a breaking change for many users that prevented upgrading.

What

This PR restores the expected behavior from the README:

It pulls the geometry automatically from its parent, optionally you can ungroup it and give it a geometry prop.
https://github.com/pmndrs/drei?tab=readme-ov-file#edges

Checklist

  • Ready to be merged

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 10:40pm

Copy link

codesandbox-ci bot commented Jun 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@CodyJasonBennett CodyJasonBennett merged commit a0c81c9 into pmndrs:master Jun 26, 2024
4 checks passed
Copy link

🎉 This PR is included in version 9.107.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<Edges> doesn't support geometry prop anymore after v9.102.0
2 participants