feat: expose Caustics materials and types as public API #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
nartc
force-pushed
the
expose-caustics
branch
5 times, most recently
from
ec72144
to
686ac6d
Compare
This PR exposes Caustics materials and types as public API
|
🎉 This PR is included in version 1.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes Caustics materials and types as public API. I didn't document the public API for the change because the current state of the README doesn't state what's exposed as public API. Please let me know if you want this documented in the README.
Why
Causticsexport only theCausticsfunction to create the entire Caustics construct and theupdatefunction. This makes it trickier for declarative framework integrations that allow for:Causticsby using their templating language (jsx, html etc...)scene)What
createCausticsUpdatefunction to create anupdatefunction that the consumers can call in their animation loop implementations.Checklist