Feature/45s update eslint plugin import #61
Conversation
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| issue: https://github.com/pmedianetwork/eslint-config/issues/45 | |||
| type: minor | |||
There was a problem hiding this comment.
I think we also have to actually set the rule:
"import/no-cycle": "error"
It is not set at all at the moment. Currently, we only have it in insights, and there, we set it to "warn".
IF we do this, it's most likely a breaking change. Do we want that @danielbartsch ❓
I am also not sure how this will integrate with typescript ... But we could just say that repos that don't want it that strict need to "downgrade" the rule "warn" for themselves .. ?
There was a problem hiding this comment.
It is a good rule to have.
If one some of the projects have issues with it, as last resort they can disable it with "import/no-cycle": 0. That could be a good opportunity to check the health of the codebase though.
There was a problem hiding this comment.
since this import-js/eslint-plugin-import#1494 is merged, I'd do it, even tho yes, it is a breaking change.
But since we have 2 other PRs merged, I'd do this after the release.
There was a problem hiding this comment.
okay, I'll make a minor release and then we can maybe do this as a breaking release, maybe together with #39
|
let's also revisit this once we have the monorepo |
Closes #45