This repository has been archived by the owner on May 22, 2023. It is now read-only.
change endpoint to use review-app #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you found my current feature branch 😅 I'm currently working on that. I tried that endpoint privately yesterday and it looks much more stable now. I plan to work a bit on this today so I would later look into merging your changes and building off from that. Thanks for opening the PR and sharing ❤️ |
pmbanugo
approved these changes
May 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had troubles setting up a review app in a case with a organisation-owned pipeline and an app.json file.
This solution now works for me. Have a look and keep if you like it.