-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Franc is providing wrong language #519
Comments
Maybe we should add a checkbox to our form if the report is for a false positive and if yes, what spam reason was set. This would help us to find the method which is the culprit. |
This was added by me in the meantime: About narrowing down the languages, maybe @MatzeKitt can chime in here and help with the API side. |
Since |
Would look like this:
|
Hey @MatzeKitt as this is a different approach to narrowing down the languages on the API side, configured through the allowed languages in WP/ASB - why are you suggesting this approach? What is the advantage to the other approach? And how complicated would it be to implement one of them? |
It is more flexible since you don’t need to manage a list of languages and test only against them but you simply need to set a threshold. This would also make the code less complex. The complexity of my solution is not high:
Your proposed solution:
Especially the first point can be more complex, since you need to either define it for all available languages or have an additional option for that, which is harder to tell the user what to do (especially since there already is an option with languages). |
Isn't this already there?
Why do you think this need to be an additional setting?
There is an |
A list of languages you want is completely different from languages franc should be able to detect. At least in my point of view. I don't know how franc behaves if you e.g. define only English and German but submit a French text. Since you would only allow English or German, I assume that franc would only output these two languages – both with a relatively low score. That wouldn’t help anything, thus you would need to define similar languages (e.g. Scottish should behave the same as English, etc.) From my point of view, limiting franc in its detection would not help us here at all. |
Describe the bug
If I use the content from Line 962/F provided via our report form I get not English but
sco
(Scots) reported and not English.Therefore the lang check is marking the comment as spam. (Needs reproducing.)
Maybe we need to narrow the languages down.
See: https://github.com/wooorm/franc#options
First reported in the forums: https://wordpress.org/support/topic/what-to-do-about-false-positives/
The text was updated successfully, but these errors were encountered: