feat(choropleth): add defs and fill capabilities #2072
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Event if it's in the documentation, the usage of
defs
andfill
was missing its implementation in the Choropleth Map component.This PR adds this features, addressing issues #2068 (and the old #864) and, with a little workaround, also the first question of #2064 (it's enough to define a gradient with the same starting and ending color to achieve what was asked).
Changelog
As was done in other components, now the Choropleth component read the
defs
andfill
, uses thebindDefs
method to bind them to the data, and pass them to theSvgWrapper
component.Then, each map
features
check is there's afill
property defined. If so it uses as fill color, otherwise it uses the calculated color.Example
This PR also adds three example patterns to the Nivo Website: