Fix tooltip positioning when charts are rendered inside an scaled div #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a normal situation mouse enter / mouse leave events capture the position ok. But when the chart is inside a scaled element with a CSS transform like: `transform: scale(2);` tooltip are not positioned ok. Comparing original width `box.width` agains scaled width give us the scaling factor to calculate ok mouse position.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c6cbb09:
|
When a Nivo chart is inside an scaled div with something like `transform: scale(2)` for example tooltips inside slides are not positoned correctly. Taking into accoun `offsetWidth` fix the issue
|
Having the same issue, could we move this forward? |
geclos
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In a normal situation mouse enter / mouse leave events capture the position ok. But when the chart is inside a scaled
element with a CSS transform like:
transform: scale(2);tooltip are not positioned ok. Comparing original widthbox.widthagains scaled width give us the scaling factor to calculate ok mouse position.The issue
This PR fix this issue
The problem
The problem as explained in the issue that when the charts are inside an scaled div like this:
The tooltip will be misplaced as you can see in the video in the issue I linked
The solution
I found the solution here