Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate stream package to TypeScript #1721

Merged
merged 8 commits into from
Aug 17, 2021
Merged

Conversation

plouc
Copy link
Owner

@plouc plouc commented Aug 15, 2021

Along with the TypeScript migration, I also made the following changes:

  • Replaced tooltipFormat with valueFormat, and add a formattedValue property on each computed datum for potential reuse
  • Replaced legendLabel and tooltipLabel with a single label property, I don't think we need 2 different properties for this
  • Added support for layers
  • Added basic unit tests
  • Added support for aria attributes on the SVG container
  • Added support for custom tooltip and stack tooltip

@plouc plouc self-assigned this Aug 15, 2021
@plouc plouc added stream @nivo/stream package typescript labels Aug 15, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 15, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f40a8c4:

Sandbox Source
nivo Configuration
nivo-website Configuration

@plouc plouc marked this pull request as ready for review August 15, 2021 09:36
@plouc plouc requested a review from wyze August 15, 2021 09:38
Copy link
Contributor

@wyze wyze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Build is erroring because of formatting in the test file.

@plouc plouc mentioned this pull request Aug 17, 2021
26 tasks
@plouc
Copy link
Owner Author

plouc commented Aug 17, 2021

Looks good. Build is erroring because of formatting in the test file.

@wyze, thx for the review, I fixed the formatting issue and added support for custom tooltips to complete another item from #192.

@plouc plouc merged commit d24f23e into master Aug 17, 2021
@plouc plouc deleted the stream-typescript-migration branch August 17, 2021 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stream @nivo/stream package typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants