-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate stream package to TypeScript #1721
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f40a8c4:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Build is erroring because of formatting in the test file.
Along with the TypeScript migration, I also made the following changes:
tooltipFormat
withvalueFormat
, and add aformattedValue
property on each computed datum for potential reuselegendLabel
andtooltipLabel
with a singlelabel
property, I don't think we need 2 different properties for this