Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bullet): add custom tooltip #1694

Merged
merged 1 commit into from
Jul 27, 2021
Merged

feat(bullet): add custom tooltip #1694

merged 1 commit into from
Jul 27, 2021

Conversation

jquintozamora
Copy link
Contributor

@jquintozamora jquintozamora commented Jul 21, 2021 •
edited
Loading

  • Add custom tooltip component as part of accepted props for <Bullet /> component

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d87451b:

Sandbox Source
nivo Configuration
nivo-website Configuration

@jquintozamora
Copy link
Contributor Author

jquintozamora commented Jul 23, 2021 •
edited
Loading

Hello @plouc , @wyze and maintainers!

I've created this PR to provide custom tooltip for bullet as part of the uncompleted tasks for this bug: #192 .

Please when have a moment let me know any feedback / missing parts / etc, happy to solve them.

Regards!

wyze
wyze approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@wyze wyze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@wyze wyze merged commit 75eafa1 into plouc:master Jul 27, 2021
@wyze wyze mentioned this pull request Jul 27, 2021
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyze wyze wyze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jquintozamora @wyze @joseq-concentra