Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BarCanvas axis text does not respect theme fontweight #1704

Closed
vanbujm opened this issue Aug 4, 2021 · 2 comments
Closed

BarCanvas axis text does not respect theme fontweight #1704

vanbujm opened this issue Aug 4, 2021 · 2 comments
Labels

Comments

@vanbujm
Copy link
Contributor

vanbujm commented Aug 4, 2021

I think the issue is here:

ctx.font = `${theme.axis.ticks.text.fontSize}px ${theme.axis.ticks.text.fontFamily}`

ctx.font should probably look like it does on line 149:

This should be the fix

ctx.font = `${
            ttheme.axis.ticks.text.fontWeight ? `${theme.axis.ticks.text.fontWeight} ` : ''
        }${theme.axis.ticks.text.fontSize}px ${theme.axis.ticks.text.fontFamily}`
@vanbujm
Copy link
Contributor Author

vanbujm commented Aug 5, 2021

Fixed in #1708

@wyze
Copy link
Contributor

wyze commented Aug 5, 2021

Thanks!

@wyze wyze closed this as completed Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants