Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect validation error for animate args info array #1265

Closed
jonmmease opened this issue Nov 6, 2018 · 3 comments
Closed

Incorrect validation error for animate args info array #1265

jonmmease opened this issue Nov 6, 2018 · 3 comments
Labels
bug something broken
Milestone

Comments

@jonmmease
Copy link
Contributor

See #1240 (comment)

These button.args assignments are valid, but raise validation errors as of 3.4.0

import plotly.graph_objs as go
button = go.layout.updatemenu.Button()
button.method = 'animate'
button.args = [['frame1', 'frame2']]
button.args = [['frame1', 'frame2'], {'frame': [{'duration': 1500}, {'duration': 500}]}]
@jonmmease
Copy link
Contributor Author

Closed by #1267. @saebaxp, could you give the 3.4.1 release candidate a try and confirm that it fixes the issue for you? Installation instructions for the release candidate at https://github.com/plotly/plotly.py/tree/release_3.4.1

Thanks again for taking the time to to report this!

@saebaxp
Copy link

saebaxp commented Nov 8, 2018

@jonmmease Thanks for the prompt fix.

Just tried comparing between 3.4.0 and 3.4.1rc.

With 3.4.0 I got ValueError:

ValueError: 
    Invalid value of type 'builtins.list' received for the 'args' property of layout.slider.step
        Received value: [['0'], {'frame': {'duration': 500.0, 'easing': 'linear', 'redraw': False}, 'transition': {'duration': 0, 'easing': 'linear'}}]

    The 'args' property is an info array that may be specified as:

    * a list or tuple of up to 3 elements where:
(0) The 'args[0]' property accepts values of any type
(1) The 'args[1]' property accepts values of any type
(2) The 'args[2]' property accepts values of any type

With 3.4.1rc the error is gone and animation works as expected.
So the issue is fixed, at least for my case.

Thanks again!

@jonmmease
Copy link
Contributor Author

Great! Thanks for giving the release candidate a try and reporting back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

2 participants