From a1f46f3c8739313f30d86ea201115d75b343dd64 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Wed, 22 May 2024 11:28:33 -0400 Subject: [PATCH 1/2] fix isosurface _vMax calculation when isomax is null --- src/traces/isosurface/calc.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/traces/isosurface/calc.js b/src/traces/isosurface/calc.js index 8e425d2ab1a..8891b15cc8b 100644 --- a/src/traces/isosurface/calc.js +++ b/src/traces/isosurface/calc.js @@ -35,7 +35,7 @@ module.exports = function calc(gd, trace) { trace._minValues = min; trace._maxValues = max; trace._vMin = (trace.isomin === undefined || trace.isomin === null) ? min : trace.isomin; - trace._vMax = (trace.isomax === undefined || trace.isomin === null) ? max : trace.isomax; + trace._vMax = (trace.isomax === undefined || trace.isomax === null) ? max : trace.isomax; colorscaleCalc(gd, trace, { vals: [trace._vMin, trace._vMax], From 404979e3a00a4ac07177dfd02f265dafc2462646 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Wed, 22 May 2024 12:15:07 -0400 Subject: [PATCH 2/2] log for PR 7002 --- draftlogs/7002_fix.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 draftlogs/7002_fix.md diff --git a/draftlogs/7002_fix.md b/draftlogs/7002_fix.md new file mode 100644 index 00000000000..a3aeb88f590 --- /dev/null +++ b/draftlogs/7002_fix.md @@ -0,0 +1 @@ + - Fix isosurface maximum value calculation when `isomax` is set to null [[#7002](https://github.com/plotly/plotly.js/pull/7002)]