From 8ce7ab214c9c0ba23a2e9d49a3d96877b336335e Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Thu, 9 Nov 2023 09:59:29 -0500 Subject: [PATCH 1/2] scatterpolargl.line should not have shape option --- src/traces/scatterpolargl/attributes.js | 8 +++++++- test/plot-schema.json | 13 ------------- 2 files changed, 7 insertions(+), 14 deletions(-) diff --git a/src/traces/scatterpolargl/attributes.js b/src/traces/scatterpolargl/attributes.js index c390163735f..a7322d3fe22 100644 --- a/src/traces/scatterpolargl/attributes.js +++ b/src/traces/scatterpolargl/attributes.js @@ -21,7 +21,13 @@ module.exports = { hovertext: scatterPolarAttrs.hovertext, hovertemplate: scatterPolarAttrs.hovertemplate, - line: scatterGlAttrs.line, + line: { + color: scatterGlAttrs.line.color, + width: scatterGlAttrs.line.width, + dash: scatterGlAttrs.line.dash, + editType: 'calc' + }, + connectgaps: scatterGlAttrs.connectgaps, marker: scatterGlAttrs.marker, diff --git a/test/plot-schema.json b/test/plot-schema.json index f5fd90c3b6f..4970a9f5752 100644 --- a/test/plot-schema.json +++ b/test/plot-schema.json @@ -58874,19 +58874,6 @@ }, "editType": "calc", "role": "object", - "shape": { - "description": "Determines the line shape. The values correspond to step-wise line shapes.", - "dflt": "linear", - "editType": "calc", - "valType": "enumerated", - "values": [ - "linear", - "hv", - "vh", - "hvh", - "vhv" - ] - }, "width": { "description": "Sets the line width (in px).", "dflt": 2, From 3e86994e8e1599f0f3382c49fd75a7ae2d44ec40 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Thu, 9 Nov 2023 10:25:08 -0500 Subject: [PATCH 2/2] log for PR 6781 --- draftlogs/6781_fix.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 draftlogs/6781_fix.md diff --git a/draftlogs/6781_fix.md b/draftlogs/6781_fix.md new file mode 100644 index 00000000000..5cd4f98d7bb --- /dev/null +++ b/draftlogs/6781_fix.md @@ -0,0 +1 @@ + - Fix plot schema not to show `line.shape` options for `scatterpolargl` trace [[#6781](https://github.com/plotly/plotly.js/pull/6781)]