Temporary fix to help improve rendering of graphs with Mathjax on Firefox v82 and higher #5993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
approved these changes
Oct 26, 2021
There was a problem hiding this comment.
Seems like a reasonable temporary fix 💃
I'll note that at one time we had quite a few nested <svg> elements, mainly to get their contents to clip, and by now we've generally (entirely aside from this?) removed them in favor of <g> with <clipPath>. So a better long-term solution may be to, instead of pulling in the whole <svg> created by MathJax, just pull its contents into the <g>. There will likely be scaling or other issues that need to be translated if we do this, but in the end it should be simpler to render, and more robust against bugs like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #5374.
Guard against bug present in Firefox v82 (and higher) https://bugzilla.mozilla.org/show_bug.cgi?id=1709251
so that incorrect values of
getBoundingClientRectdo not totally confuse rendering pipeline.@plotly/plotly_js