Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix histogram bingroup algo when calendars module is not registered #4439

Merged
merged 2 commits into from
Dec 24, 2019

Conversation

etpinard
Copy link
Contributor

By adding a fallback in the trace calendar getter in Histogram.crossTraceCalc so that when the Calendars module isn't registered (thus making _fullData[i].(x|y)calendar === undefined), we're still able to group traces in the correct bin groups.

fixes #4429

Note also, that at present we only register calendars in the "main" plotly.js bundles:

plotly.js/lib/index.js

Lines 92 to 95 in 97ba9c3

// components
Plotly.register([
require('./calendars')
]);

cc @archmoj

... so that when the Calendars module isn't registered (thus making
    `_fullData[i].(x|y)calendar` undefined), we're still
    able to group traces in the correct bin groups
@etpinard etpinard added bug something broken status: reviewable labels Dec 23, 2019
@archmoj
Copy link
Contributor

archmoj commented Dec 23, 2019

Nicely done.
💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong bar layout on the horizontal axis when using 'histogram' in plotly-cartesian
2 participants