Fix histogram bingroup algo when calendars module is not registered #4439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding a fallback in the trace calendar getter in
Histogram.crossTraceCalc
so that when the Calendars module isn't registered (thus making_fullData[i].(x|y)calendar === undefined
), we're still able to group traces in the correct bin groups.fixes #4429
Note also, that at present we only register
calendars
in the "main" plotly.js bundles:plotly.js/lib/index.js
Lines 92 to 95 in 97ba9c3
cc @archmoj