Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of textinfo for waterfall traces #3790

Merged
merged 65 commits into from
May 8, 2019
Merged

Implementation of textinfo for waterfall traces #3790

merged 65 commits into from
May 8, 2019

Commits on Apr 18, 2019

  1. waterfall text info

    @archmoj
    archmoj committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    4a6c7c9 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2019

  1. added label option - fixup computed value - improve mock and print order

    @archmoj
    archmoj committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    64f32e0 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2019

  1. rename new mock filename i.e. hoverinfo > textinfo

    @archmoj
    archmoj committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    f33bed1 View commit details
    Browse the repository at this point in the history

  2. revised flag order and output

    @archmoj
    archmoj committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    711a16d View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into fix3777-textinfo-wa… 

    …terfall-fin
    @archmoj
    archmoj committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    a2e6e5b View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2019

  1. replace pie helpers with ax ticktext - fixup and added tests

    @archmoj
    archmoj committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    cd5f09f View commit details
    Browse the repository at this point in the history

  2. add funnel - changes to lib

    @archmoj
    archmoj committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    3832e01 View commit details
    Browse the repository at this point in the history

  3. add funnel - changes to src plot plot_api and legend style

    @archmoj
    archmoj committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    dd5ff48 View commit details
    Browse the repository at this point in the history

  4. add funnel - chanegs to bar

    @archmoj
    archmoj committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    8846193 View commit details
    Browse the repository at this point in the history

  5. add funnel - new trace files

    @archmoj
    archmoj committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    cad13aa View commit details
    Browse the repository at this point in the history

  6. add funnel test - mocks and baselines

    @archmoj
    archmoj committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    87b1c44 View commit details
    Browse the repository at this point in the history

  7. add funnel jasmine test

    @archmoj
    archmoj committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    424d6f5 View commit details
    Browse the repository at this point in the history

  8. revisions after etpinard comments

    @archmoj
    archmoj committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    aec946e View commit details
    Browse the repository at this point in the history

  9. add comment to describe how trace._base is different than trace.base … 

    …for funnel traces
    @archmoj
    archmoj committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    4fb5a2b View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2019

  1. clean up bar cross calc - pass prefix - remove mockGd from funnel and… 

    … waterfall
    @archmoj
    archmoj committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    75a5cb4 View commit details
    Browse the repository at this point in the history

  2. combine blank horizontal and vertical bar text mocks in one

    @archmoj
    archmoj committed Apr 30, 2019
    4 Configuration menu
    Copy the full SHA
    1504463 View commit details
    Browse the repository at this point in the history

  3. reduced number of funnel mocks

    @archmoj
    archmoj committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    1434148 View commit details
    Browse the repository at this point in the history

  4. remove unused handleGroupingDefaults exports from funnel and waterfal… 

    …l defaults
    @archmoj
    archmoj committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    68bd371 View commit details
    Browse the repository at this point in the history

  5. remove unused node3 link from funnel and waterfall plots

    @archmoj
    archmoj committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    3d5b8ff View commit details
    Browse the repository at this point in the history

  6. describe non-arrayOk textinfo flags

    @archmoj
    archmoj committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    8d02bcf View commit details
    Browse the repository at this point in the history

  7. cut category types from funnel axis mocks and add anchors

    @archmoj
    archmoj committed Apr 30, 2019
    1 Configuration menu
    Copy the full SHA
    c6155db View commit details
    Browse the repository at this point in the history

  8. rm autorange true

    @archmoj
    archmoj committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    020a34b View commit details
    Browse the repository at this point in the history

  9. finalize connector line and region edit types

    @archmoj
    archmoj committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    4c741c7 View commit details
    Browse the repository at this point in the history

  10. revise funnel select and fixup select test

    @archmoj
    archmoj committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    eea4a72 View commit details
    Browse the repository at this point in the history

  11. fixup axis anchors and added histogram case in image tests

    @archmoj
    archmoj committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    9507640 View commit details
    Browse the repository at this point in the history

  12. fixup new waterfall_axis mock

    @archmoj
    archmoj committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    3159fab View commit details
    Browse the repository at this point in the history

  13. dont coerce waterfall textinfo if textposition is none

    @archmoj
    archmoj committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    bed6842 View commit details
    Browse the repository at this point in the history

  14. pass opts to bar cross trace calc

    @archmoj
    archmoj committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    86c0c09 View commit details
    Browse the repository at this point in the history

  15. remove one more unused node3 link

    @archmoj
    archmoj committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    bdbbeb1 View commit details
    Browse the repository at this point in the history

  16. add jasmine tests of waterfall textinfo coerce

    @archmoj
    archmoj committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    6ac1dc5 View commit details
    Browse the repository at this point in the history

  17. need extra precision in textinfo values of funnel and waterfall

    @archmoj
    archmoj committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    cad2728 View commit details
    Browse the repository at this point in the history

  18. dont coerce funnel textinfo if textposition is none - also add jasmin… 

    …e test
    @archmoj
    archmoj committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    92b9471 View commit details
    Browse the repository at this point in the history

  19. add noCI tag for one sankey test which started to fail after adding f… 

    …unnel tests
    @archmoj
    archmoj committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    34e0a4b View commit details
    Browse the repository at this point in the history

  20. fixup waterfall jasmine test for textinfo - note value was not a vali… 

    …d flag for waterfalls
    @archmoj
    archmoj committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    7e52977 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2019

  1. refactor bar waterfall and funnle plot - rm prefix - pass opts

    @archmoj
    archmoj committed May 1, 2019
    Configuration menu
    Copy the full SHA
    ba1b6c0 View commit details
    Browse the repository at this point in the history

  2. revisit bar-like hideOutsideRangePoints

    @archmoj
    archmoj committed May 1, 2019
    Configuration menu
    Copy the full SHA
    04049f2 View commit details
    Browse the repository at this point in the history

  3. default fillcolor to marker.color

    @archmoj
    archmoj committed May 1, 2019
    Configuration menu
    Copy the full SHA
    6c8a661 View commit details
    Browse the repository at this point in the history

  4. drop funnelnorm

    @archmoj
    archmoj committed May 1, 2019
    Configuration menu
    Copy the full SHA
    2a3c354 View commit details
    Browse the repository at this point in the history

  5. waterfall hover bug fix

    @archmoj
    archmoj committed May 1, 2019
    Configuration menu
    Copy the full SHA
    1c82f91 View commit details
    Browse the repository at this point in the history

  6. add jasmine test to lock waterfall hover on different types of measur… 

    …es - and improve waterfall textinfo mock with cliponaxis false and axis tick prefix and suffix
    @archmoj
    archmoj committed May 1, 2019
    Configuration menu
    Copy the full SHA
    6a3a13c View commit details
    Browse the repository at this point in the history

  7. coerce tick label defaults even if axis is not visible i.e. required … 

    …to format textinfo - improve image test and jasmine test for textinfo - fix textinfo and hover percent formats in funnel
    @archmoj
    archmoj committed May 1, 2019
    Configuration menu
    Copy the full SHA
    35dfe36 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2019

  1. refactor layout defaults before addressing nXn loop issue

    @archmoj
    archmoj committed May 2, 2019
    Configuration menu
    Copy the full SHA
    c63caf9 View commit details
    Browse the repository at this point in the history

  2. drop arrayOk support of bar width and offset of funnels - improve fil… 

    …lcolor default logic - fixup tests
    @archmoj
    archmoj committed May 2, 2019
    Configuration menu
    Copy the full SHA
    f249c61 View commit details
    Browse the repository at this point in the history

  3. revise draw order for funnel connector regions and lines

    @archmoj
    archmoj committed May 2, 2019
    Configuration menu
    Copy the full SHA
    d6f023a View commit details
    Browse the repository at this point in the history

  4. improve image test to contain one overlay example

    @archmoj
    archmoj committed May 2, 2019
    Configuration menu
    Copy the full SHA
    0c169b5 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2019

  1. revisit textinfo and width defaults - fix and improve tests

    @archmoj
    archmoj committed May 3, 2019
    Configuration menu
    Copy the full SHA
    c29b58d View commit details
    Browse the repository at this point in the history

  2. split handleTickLabelDefaults and split the process into two passes t… 

    …o coerce prefix and suffix for invisible axes - as required in funnel and waterfall textinfo
    @archmoj
    archmoj committed May 3, 2019
    Configuration menu
    Copy the full SHA
    e968da6 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2019

  1. implement textangle for bars funnels and waterfalls - add tests

    @archmoj
    archmoj committed May 4, 2019
    Configuration menu
    Copy the full SHA
    380db2e View commit details
    Browse the repository at this point in the history

  2. fix alignmentgroup attributes of funnel and waterfall

    @archmoj
    archmoj committed May 4, 2019
    Configuration menu
    Copy the full SHA
    61b6068 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2019

  1. refactor bar inside text if statement

    @archmoj
    archmoj committed May 6, 2019
    Configuration menu
    Copy the full SHA
    0236783 View commit details
    Browse the repository at this point in the history

  2. revert cartesian layout_default file

    @archmoj
    archmoj committed May 6, 2019
    Configuration menu
    Copy the full SHA
    4d403fd View commit details
    Browse the repository at this point in the history

  3. minimal change to add logic to hide funnels

    @archmoj
    archmoj committed May 6, 2019
    Configuration menu
    Copy the full SHA
    a650170 View commit details
    Browse the repository at this point in the history

  4. drop texangle and position defaults from funnel mocks

    @archmoj
    archmoj committed May 6, 2019
    Configuration menu
    Copy the full SHA
    a744689 View commit details
    Browse the repository at this point in the history

  5. fixup textangle algo - added test for outside text

    @archmoj
    archmoj committed May 6, 2019
    Configuration menu
    Copy the full SHA
    30b172a View commit details
    Browse the repository at this point in the history

  6. fix outside long text position with textangle - add test

    @archmoj
    archmoj committed May 6, 2019
    Configuration menu
    Copy the full SHA
    446bacc View commit details
    Browse the repository at this point in the history

  7. default funnels to horizontal

    @archmoj
    archmoj committed May 6, 2019
    Configuration menu
    Copy the full SHA
    b93e3a5 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2019

  1. handle multicategory labels in funnel and waterfall textinfo

    @archmoj
    archmoj committed May 7, 2019
    Configuration menu
    Copy the full SHA
    02a176a View commit details
    Browse the repository at this point in the history

  2. add logic to reverse y axis by default if only funnels

    @archmoj
    archmoj committed May 7, 2019
    Configuration menu
    Copy the full SHA
    d0e8fe5 View commit details
    Browse the repository at this point in the history

  3. remove yaxis autorange reversed from funnel mocks

    @archmoj
    archmoj committed May 7, 2019
    Configuration menu
    Copy the full SHA
    0eb3917 View commit details
    Browse the repository at this point in the history

  4. improve funnel orientation description and do base waterfall and funn… 

    …el textinfo attr on pie
    @archmoj
    archmoj committed May 7, 2019
    Configuration menu
    Copy the full SHA
    fd1f6ca View commit details
    Browse the repository at this point in the history

  5. revisit transform inside bar to reduce diff after textangle - revert … 

    …bar_attrs_relative to original
    @archmoj
    archmoj committed May 7, 2019
    Configuration menu
    Copy the full SHA
    6d50386 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #3817 from plotly/funnel-traces 

    Funnel traces
    @archmoj
    archmoj authored May 7, 2019
    Configuration menu
    Copy the full SHA
    79d6ef1 View commit details
    Browse the repository at this point in the history

  7. fixup after merge of funnel

    @archmoj
    archmoj committed May 7, 2019
    Configuration menu
    Copy the full SHA
    154e81e View commit details
    Browse the repository at this point in the history

Commits on May 8, 2019

  1. textinfo do not leave a blank line when text is empty but print zero

    @archmoj
    archmoj committed May 8, 2019
    Configuration menu
    Copy the full SHA
    a598343 View commit details
    Browse the repository at this point in the history

  2. improve jasmine tests for textinfo

    @archmoj
    archmoj committed May 8, 2019
    Configuration menu
    Copy the full SHA
    d69f8a4 View commit details
    Browse the repository at this point in the history