Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix category init for non-matching axes on graphs with matching axes #3565

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Fix category init for non-matching axes on graphs with matching axes #3565

merged 2 commits into from
Feb 21, 2019

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard added bug something broken status: reviewable labels Feb 21, 2019
archmoj
archmoj reviewed Feb 21, 2019
View reviewed changes
Copy link
Contributor

@archmoj archmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etpinard Thanks for the PR.
Please find my questions below.

src/plots/cartesian/set_convert.js Outdated Show resolved Hide resolved
src/plots/cartesian/set_convert.js Outdated Show resolved Hide resolved
@etpinard
improve ax.clearCalc:
598a67b 
- mv for-else call after for loop
- rename init() -> emptyCategories()
- break after finding group in which ax is in - as one ax can
  only be in a single match group at a time.
@archmoj
Copy link
Contributor

archmoj commented Feb 21, 2019

Looks good.
💃

@etpinard etpinard merged commit 9ef8617 into master Feb 21, 2019
@etpinard etpinard deleted the matching-axes-category-and-linear branch February 21, 2019 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archmoj archmoj archmoj left review comments

Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using matches when opposite axis is categorical causes error
2 participants
@etpinard @archmoj