Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pie title #2987

Merged
merged 6 commits into from
Sep 28, 2018
Merged

Pie title #2987

merged 6 commits into from
Sep 28, 2018

Commits on Sep 5, 2018

  1. Add an optional title to pie charts.

    The title can be shown either inside the hole (if there is one),
    or outside. If the title is placed outside, the algorithm tries to
    position it so that it does not intersect labels or pulled slices.
    codrut3 committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    4676fd8 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2018

  1. Configuration menu
    Copy the full SHA
    79b00ab View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2018

  1. Add more options to titleposition.

    This commit changes titleposition to be of the form 'top left',
    'top center', ... I added unit tests for correct placement in all
    possible positions. I also added mocks using multiline titles.
    codrut3 committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    ed86959 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    96e3afd View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2018

  1. Remove default option for titleposition.

    If it is undefined, titleposition is set to 'middle center', if hole > 0,
    and to 'top center' otherwise. _verifyTitle now returns a promise.
    codrut3 committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    97cc9bb View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2018

  1. Configuration menu
    Copy the full SHA
    bce5add View commit details
    Browse the repository at this point in the history