-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attributions display twice on mapbox
#7075
Comments
Strangely enough if I call python3 test/image/make_baseline.py mapbox_0 It works just fine. npm run baseline mapbox_0 fails although it calls the same python script using node.js! 🤯 |
@birkskyum this issue doesn't seem related to your PR; although it start showing up after we merged the Anyway I was not able to figure out what causes this. |
@birkskyum Yes the same commit before merging maplibre PR passed the tests. |
Could you send a screenshot? |
@birkskyum That looks like a different bug. No? |
@archmoj , yes, maybe separate but can't say for sure. I made a ticket for that and removed the noise about it from this ticket. |
I skipped those mapbox tests on CI in #7083. |
The image tests are failing on master after merging #7060: https://app.circleci.com/pipelines/github/plotly/plotly.js/10950/workflows/2c1cc796-b8cd-47b9-adcc-328d0ae4a9f2/jobs/242299/parallel-runs/0/steps/0-102
This is not related to #7060 itself since if I checkout
v2.34.0
then
Gives me the baseline with duplicate source attribution!
I suspect this was related to the order of rendering on CI but somehow wasn't noticed before.
The text was updated successfully, but these errors were encountered: