Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set 'colorbar' parameters in layout.template.data.{trace}[i].{line|marker} #4467

Closed
wbrgss opened this issue Jan 6, 2020 · 2 comments · Fixed by #4470
Closed

Can't set 'colorbar' parameters in layout.template.data.{trace}[i].{line|marker} #4467

wbrgss opened this issue Jan 6, 2020 · 2 comments · Fixed by #4470
Assignees
Labels
bug something broken

Comments

@wbrgss
Copy link
Contributor

wbrgss commented Jan 6, 2020

Setting colorbar parameters doesn't appear to work in layout.template.data.{trace_type}[i].{line|marker}.

Related: #3100 (comment), to quote @etpinard:

As for the colorbar part, the problem comes from the colorbar defaults call:

if(showScale) colorbarDefaults(containerIn, containerOut, layout);

where containerOut is fullData[i] for heatmap, but is fullData[i].marker for scatter and other marker colorscales. Colorbar templates propagate correctly (using Template.newContainer) from fullData[i], but not from marker containers. Adding

image

should be enough to fix this, but we should look for other situations where supply-defaults subroutines are called with trace sub-containers.


I'm not sure the above suggested fix was ever implemented.

This codepen demonstrates the issue with ypad:
https://codepen.io/wbrgss/pen/NWPXEPG

I logged a separate issue related to #3100 in #4466

@wbrgss
Copy link
Contributor Author

wbrgss commented Jan 6, 2020

To be more specific, I've noticed this for line as well as marker colorscales, including scatter but also parcats and splom.

@etpinard
Copy link
Contributor

etpinard commented Jan 7, 2020

Thanks for pointing this out.

I botched 6a47d66 for colorbar containers.


Please note that line colorscales are not supported in scatter lines (they are in marker.line) and that splom traces only support markers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants