all textinfo/hoverinfo flags should be available to hovertemplate

[nicolaskruchten]

Following on from #3954 ... I'm not sure if this is or isn't the case for pie already, but it should be 🔒'ed down please :)

[archmoj]

Thanks for the report.
The percent flag seem to be not available in hoverinfo of pie & funnelarea.

[archmoj]

Correction: there is no issue found with pie and funnelarea with percent flag.

[etpinard]

@archmoj how's our test coverage for funnelarea + hoverinfo and hovertemplate ?

[archmoj]

@archmoj how's our test coverage for funnelarea + hoverinfo and hovertemplate ?

I think that is pretty good.

For hovertemplate we have:

plotly.js/test/jasmine/tests/funnelarea_test.js

Lines 965 to 993 in d7d2bdd

	return Plotly.restyle(gd, 'hovertemplate', '%{percent}<extra></extra>');
	})
	.then(_hover)
	.then(function() {
	assertLabel(
	['33.3%'].join('\n'),
	null,
	'hovertemplate %{percent}'
	);
	return Plotly.restyle(gd, 'hovertemplate', '%{label}<extra></extra>');
	})
	.then(_hover)
	.then(function() {
	assertLabel(
	['0'].join('\n'),
	null,
	'hovertemplate %{label}'
	);
	})
	.then(function() { return Plotly.restyle(gd, 'hovertemplate', [['ht 5 %{percent:0.2%}<extra></extra>', '', '', '', '']]); })
	.then(_hover)
	.then(function() {
	assertLabel(
	['ht 5 33.33%'].join('\n'),
	null,
	'hovertemplate arrayOK'
	);
	})

And for hoverinfo we have:

plotly.js/test/jasmine/tests/funnelarea_test.js

Lines 877 to 892 in d7d2bdd

	return Plotly.restyle(gd, 'hoverinfo', [['label+percent', null, null, null, null]]);
	})
	.then(_hover)
	.then(function() {
	assertLabel(['0', '33.3%'].join('\n'), null, 'new hoverinfo');
	return Plotly.restyle(gd, 'hoverinfo', [['dont+know+what+im-doing', null, null, null, null]]);
	})
	.then(_hover)
	.then(function() {
	assertLabel(
	['0', 'SUP', '5', '33.3%'].join('\n'),
	null,
	'garbage hoverinfo'
	);
	})

[etpinard]

Yep, good enough.

I think you can close this issue @archmoj