Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pan draw error in scattergl + rangeslider and multiple yaxis #2830

Closed
nZo-sp opened this issue Jul 20, 2018 · 8 comments
Closed

Pan draw error in scattergl + rangeslider and multiple yaxis #2830

nZo-sp opened this issue Jul 20, 2018 · 8 comments

Comments

@nZo-sp
Copy link

nZo-sp commented Jul 20, 2018

https://codepen.io/anon/pen/NBbZEg

Actually im using a scattergl plot in a sort of "mixed mode":

  • Drawing one trace with scatter in order to enable rangeslider preview
  • Drawing all other traces with scattergl in order to have a boost in FPS and CPU usage
    Using this configuration if the user tries to pan, all the scatterlg traces are painted erroneously:

image

This seems related to the fact that rangeslider is rendered as last.
When rendered the rangeslider sets the viewport and remains unchanged while panning.

This seems fix the problem:
https://github.com/vincex/plotly.js/pull/2

@etpinard
Copy link
Contributor

Thanks for writing in.

This is what I'm seeing off your vincex#2:

image

which doesn't seem to solve the double drawing problem.

Moreover, I would be reluctant to merge your patch as it could potentially slow down a hot code patch.

I think we should instead dedicate our efforts towards #2627

@nZo-sp
Copy link
Author

nZo-sp commented Jul 20, 2018

Ok, we will wait for #2627.
The strange thing is that in my environment the double line bug is not visible instead in a pen with the exact same layout/traces configuration copied from my environment the double line is visible. Thats weird.

@etpinard
Copy link
Contributor

my environment the double line bug is not visible

Are you using a different plotly.js version?

@nZo-sp
Copy link
Author

nZo-sp commented Jul 20, 2018

node_modules\plotly.js\dist\plotly.js from 1.39.2 available in npm.

Im trying to replicate even the init flow.
Usually i have axes and traces added dynamically so there are a bunch of relayout and addtraces in the process. Ill let you know if i find something

@nZo-sp
Copy link
Author

nZo-sp commented Jul 20, 2018

Here a pen with the full flow, but the doubletrace bug is still there.
https://codepen.io/anon/pen/NBbZEg

Here a shoot of what I have in my environment
image

@etpinard
Copy link
Contributor

Hmm https://codepen.io/anon/pen/NBbZEg gives me:

image

Strange.

Oh well, there's probably a lot more things that aren't working properly on scattergl+rangeslider graphs.

Ok if I merge this ticket with #2627 ?

@nZo-sp
Copy link
Author

nZo-sp commented Jul 23, 2018

That is perfectly fine #2627 share the same goal.

@etpinard
Copy link
Contributor

Thanks for your help @VinceX !

Merging with #2627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants