Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scattergl box/lasso selection on broken overlaying-y-axis subplots #2797

Closed
nZo-sp opened this issue Jul 10, 2018 · 3 comments
Closed

Scattergl box/lasso selection on broken overlaying-y-axis subplots #2797

nZo-sp opened this issue Jul 10, 2018 · 3 comments
Labels
bug something broken

Comments

@nZo-sp
Copy link

nZo-sp commented Jul 10, 2018

https://codepen.io/anon/pen/BPaQOe?editors=1010

If you try to select some points with lasso or box selection only the last added trace is visible.
The "autoscale" buttons fix the visualization problem until a new selection is made.

I dont have a deep knowledge of ploty and I am not able to investigate further. But from what i was able to see seems that with the autoscale the redraw of each subplot is in sync, instead with the selection the redraw of each subplot is async and only the last one is redrawed.

Thanks for your time guys.
@etpinard
Copy link
Contributor

Thanks for the report!

@etpinard etpinard added the bug something broken label Jul 10, 2018
@etpinard etpinard changed the title Scattergl box/lasso selection shows only the last added trace Scattergl box/lasso selection on broken multi-y-axis subplots Jul 10, 2018
@etpinard
Copy link
Contributor

Related to #2562, which might be the best way to fix this bug.

@dy what do you think?

@etpinard etpinard changed the title Scattergl box/lasso selection on broken multi-y-axis subplots Scattergl box/lasso selection on broken overlaying-y-axis subplots Jul 10, 2018
@etpinard
Copy link
Contributor

More minimal reproducible example: https://codepen.io/etpinard/pen/ajbGOx

@etpinard etpinard mentioned this issue Aug 13, 2018
Merged
etpinard added a commit that referenced this issue Oct 2, 2018
@etpinard
fix #2797 - clear full canvas and use redrawReglTraces on selections
33e5370 
- no longer need _module.styleOnSelect!
- selections on overlaid subplots now work!
- remove clearViewport (for now), we could bring it back
  again to optimize selections on disjoint subplots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nZo-sp @etpinard