-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up cartesian axes supplyDefaults #2549
Comments
Some more observations:
Lines 820 to 855 in 4ed586a
for every anchor-less axis, it loops over all subplots. So I'm thinking of moving this block out of |
Sounds reasonable. Another option - not necessarily mutually exclusive, we could do both in fact - would be to make another collation of subplots that maps each (x|y) axis onto the (y|x) axes it makes subplots with. That should substantially reduce the size and complexity of loops like this. |
From #3070 (comment), 50 dims splom traces spend about 40ms in |
Referencing #749 - moving away from the "relink everything approach" should speed up |
Hi - this issue has been sitting for a while, so as part of our effort to tidy up our public repositories I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our stack. Cheers - @gvwilson |
From #2527, Plots.supplyDefaults takes > 100ms at 50x50 subplots which feels like an eternity when zooming.
indexOf
into axis lists would be a good start (perhaps experimenting with ES6Map
andSet
could be worthwhile)Plots.supplyDefaults
pathway, that would only update a subset of the graph's cartesian axes and their dependencies.The text was updated successfully, but these errors were encountered: