Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump electron to 6.1.4 #266

Merged
merged 6 commits into from
Jan 8, 2020
Merged

bump electron to 6.1.4 #266

merged 6 commits into from
Jan 8, 2020

Conversation

antoinerg
Copy link
Collaborator

@antoinerg antoinerg commented Nov 12, 2019

This PR supersedes PR #237 and bumps electron from 1.8.4 to 6.1.4. The version of the bundled Chromium goes from v59 to v76.

Although most SVG baselines stayed the same, there are slight differences in rendering for the other baselines (most certainly due to switching to a much newer version of Chromium!).

TODO:

Nice to have:

@antoinerg antoinerg mentioned this pull request Nov 12, 2019
@antoinerg antoinerg changed the title bump electron to 6.0.8 bump electron to 6.1.4 Nov 12, 2019
@antoinerg
Copy link
Collaborator Author

antoinerg commented Dec 17, 2019

Comparing PDF of DDK apps:
New: https://3931-99037241-gh.circle-artifacts.com/0/test_dash_previews/report_graph.pdf
Old: https://3933-99037241-gh.circle-artifacts.com/0/test_dash_previews/report_graph.pdf

  • We can see that the white boxes now have a shadow. Is that intentional?
  • Somehow, the first plot has the mode bar displayed :\ It seems to be case for other PDFs as well
    such as this one. This wasn't the case before!

cc @wbrgss @chriddyp

@wbrgss
Copy link

wbrgss commented Dec 17, 2019

@antoinerg The shadow should be there; it is on the web report. I'd say this is an improvement from the upgrade

The modebar shouldn't be there. I notice it's only on the first graph. Is is being focused or even "hovered" somehow?

@antoinerg
Copy link
Collaborator Author

The modebar shouldn't be there. I notice it's only on the first graph. Is is being focused or even "hovered" somehow?

This one is a strange regression. I'm surprised by how reproducible it is: the modebar always appears if a graph is near the top of the first page. I saw this issue before when working on dash-snapshots but it was intermittent. Anyway, it seems like 22032a4 fixes the issue 🎉

@antoinerg
Copy link
Collaborator Author

Ok, so it seems like the major blocking issues have been resolved for this one and it should get merged in the near future.

@plotly/devops, I deployed this branch on stage and made sure it works in Chart studio. You might want to battle test it further to see how well it behaves under load.

@etpinard
Copy link
Contributor

etpinard commented Jan 8, 2020

💃

@etpinard
Copy link
Contributor

etpinard commented Jan 8, 2020

An early candidate for PR of the year 2020

@antoinerg antoinerg merged commit 1208c5b into master Jan 8, 2020
@antoinerg antoinerg deleted the pr-bump-electron-6 branch January 8, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants