-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump electron to 6.1.4 #266
Conversation
@antoinerg The shadow should be there; it is on the web report. I'd say this is an improvement from the upgrade The modebar shouldn't be there. I notice it's only on the first graph. Is is being focused or even "hovered" somehow? |
This one is a strange regression. I'm surprised by how reproducible it is: the modebar always appears if a graph is near the top of the first page. I saw this issue before when working on |
Ok, so it seems like the major blocking issues have been resolved for this one and it should get merged in the near future. @plotly/devops, I deployed this branch on stage and made sure it works in Chart studio. You might want to battle test it further to see how well it behaves under load. |
💃 |
An early candidate for PR of the year 2020 |
This PR supersedes PR #237 and bumps electron from
1.8.4
to6.1.4
. The version of the bundled Chromium goes fromv59
tov76
.Although most SVG baselines stayed the same, there are slight differences in rendering for the other baselines (most certainly due to switching to a much newer version of Chromium!).
TODO:
master
. cc @wbrgssNice to have: