-
-
Notifications
You must be signed in to change notification settings - Fork 281
elasticsearch: handle case when user forgets to set port number #317
Comments
Nicolas, Thanks |
Before we go and enforce the port with Elastic Search I think it might be a good idea to leave it as optional. I am working my way through a related ElasticSearch issue (#316 ) and by making the port optional it is allowing me to connect to ElasticSearch cluster behind a NGINX server. |
No, that's not what I mean. At the moment, when Falcon connects to an elasticsearch server, it requests We need a more robust way to confirm the user has given us the right URL (regardless of whether that URL has a port number or not). |
Ok makes sense. If you want help fixing this let me know. As I mentioned in issue #316 I am currently working my way through Elasticsearch.js to figure out what is causing the 400 error. |
I was looking back at this issue and I was able to get ElasticSearch back up and running. I wanted to see about solutions to validate the url. Would you be looking for something like performing a regex evaluation of the url string? Or would you like a solution which tries to connect to the ElasticSearch server and validate that it is up and running? If it is the regex expression, I can throw together a regex expression and a PR pretty quickly |
@shannonlal I'm working on this connector in PR #343 (I'll address this issue there). |
See #316 (comment)
The text was updated successfully, but these errors were encountered: