Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Make our own dropdown component (phase out react-select) #250

Open
Marc-Andre-Rivet opened this issue Nov 22, 2018 · 3 comments
Open

Make our own dropdown component (phase out react-select) #250

Marc-Andre-Rivet opened this issue Nov 22, 2018 · 3 comments
Labels
dash-type-maintenance Technical debt, dependency management, additional testing, etc.

Comments

@Marc-Andre-Rivet
Copy link
Contributor

We are currently locked into a old(ish) version 1.2.1 of https://www.npmjs.com/package/react-select and can't easily migrate to the new 2.x version because of a hardcoded styling dependency (

import 'react-select/dist/react-select.css';
)

We've encountered multiple styling and implementation issues with this dropdown (height changing, width forcing, positioning issues within a table with fixed rows/columns -- causing special implementation needs for said "fixed" options, etc.) and we should consider either using another pre-made component or building our own to better fit the needs of the table.

@Marc-Andre-Rivet Marc-Andre-Rivet added Attribute: Supportability dash-type-maintenance Technical debt, dependency management, additional testing, etc. labels Nov 22, 2018
@bpostlethwaite
Copy link
Member

I support this and not only for dash-table but across all our dash repos. Though we can and probably should do this incrementally and start in dash-table. react-select isn't saving us time given how complex its styling is and how brittle our react-select styling integration has become. It's a freaking dropdown.

@Marc-Andre-Rivet
Copy link
Contributor Author

@bpostlethwaite Yes!

@valentijnnieman
Copy link
Contributor

I'm currently looking into some DCC.Dropdown bugs, most of them I can't fix because they're residing in the react-virtualized-select package, which is no longer maintained. That package uses react-select version 1.0 internally by the way, and even though our deps have react-select 2.0 (which isn't used anywhere) we're still stuck with version 1.0. I'm currently trying to replace react-virtualized-select with react-select, but not sure about that solution (large datasets?), but if we're building our own Dropdown component... I'd say that's a much better solution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dash-type-maintenance Technical debt, dependency management, additional testing, etc.
Projects
None yet
Development

No branches or pull requests

3 participants