Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

The native react-markdown code renderer should be used for syntax highlighting customization. #724

Open
shammamah-zz opened this issue Dec 18, 2019 · 0 comments
Open

The native react-markdown code renderer should be used for syntax highlighting customization. #724

shammamah-zz opened this issue Dec 18, 2019 · 0 comments
Milestone
Dash Q1/2020

Comments

@shammamah-zz
Copy link
Contributor

shammamah-zz commented Dec 18, 2019 •
edited
Loading

I think the existing implementation does not take full advantage of the react-markdown ability to get its renderer overriden -- similarly to https://github.com/plotly/dash-core-components/pull/711/files#diff-5b56ed82805404e28302aef5147d04a2R129 it should be possible to hook up the highlight directly onto the code renderer and simplify this component / usage.

Originally posted by @Marc-Andre-Rivet in #720
@shammamah-zz shammamah-zz added this to the Dash Q1/2020 milestone Dec 18, 2019
@shammamah-zz shammamah-zz changed the title The native react-markdown code renderer should be used for highlights customization. The native react-markdown code renderer should be used for syntax highlighting customization. Dec 18, 2019
@Marc-Andre-Rivet Marc-Andre-Rivet mentioned this issue Dec 19, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Dash Q1/2020
Development

No branches or pull requests
1 participant
@shammamah-zz