You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
We've discovered that plotly.js mutates not just the figure (which caused the Graph resizing bug in Tabs #279) but also the data. Our contract with props in our components is that they are immutable, so that subsequent renders of the components will not cause side-effects. We've solved the issue of the Graph resizing by cloning the figure.layout array. We could do this with data as well, but the data could get very big, and cloning that on every render could get very expensive very quickly. At some point, it would be nice to make sure that data and other props passed to plotly.js are treated as immutable.
The text was updated successfully, but these errors were encountered:
We've discovered that
plotly.js
mutates not just thefigure
(which caused the Graph resizing bug in Tabs #279) but also thedata
. Our contract with props in our components is that they are immutable, so that subsequent renders of the components will not cause side-effects. We've solved the issue of the Graph resizing by cloning thefigure.layout
array. We could do this withdata
as well, but thedata
could get very big, and cloning that on every render could get very expensive very quickly. At some point, it would be nice to make sure thatdata
and other props passed toplotly.js
are treated as immutable.The text was updated successfully, but these errors were encountered: