Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename default distribution to volto #162

Merged
merged 4 commits into from
Nov 10, 2024
Merged

Rename default distribution to volto #162

merged 4 commits into from
Nov 10, 2024

Conversation

davisagli
Copy link
Member

Fixes #161

The only tricky bit here is that the name of the distribution is stored persistently, so we need an upgrade step to update that reference.

@mister-roboto
Copy link

@davisagli thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

How can I actually test this PR? My guess is to run Cookieplone to generate a project, then make the same replacements you made here in the project. Before I spend time on that guess, I'd appreciate any guidance. Thank you!

@davisagli
Copy link
Member Author

@stevepiercy No, this isn't a template for changes to make in a project. A Cookieplone project installs Plone, which depends on both plone.volto and plone.classicui, providing the 2 built-in distributions. This change won't be available in a cookieplone project until there's a new release including this change.

You have 2 options for testing:

  1. In this repository, run make install, then make start, and open http://localhost:8080
  2. Use buildout.coredev, make sure plone.volto is checked out from this branch, start the instance and open http://localhost:8080

@davisagli
Copy link
Member Author

@jenkins-plone-org please run jobs

@davisagli davisagli merged commit ffad222 into main Nov 10, 2024
11 checks passed
@davisagli davisagli deleted the rename-dist branch November 10, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename distribution from default to volto
3 participants