Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plone.volto.multilingual must not install langauge settings #151

Open
jensens opened this issue Jun 17, 2024 · 4 comments
Open

plone.volto.multilingual must not install langauge settings #151

jensens opened this issue Jun 17, 2024 · 4 comments

Comments

@jensens
Copy link
Member

jensens commented Jun 17, 2024

We install English and Italian and German here:
https://github.com/plone/plone.volto/blob/main/src/plone/volto/profiles/multilingual/registry.xml

I do think we should make such a choice here. Otherwise one with other choices need to remove the language after using the profile.

Otherwise, if it is a test-profile only, not intended to be used outside of testing, it should be named explicit as such.

@davisagli
Copy link
Member

davisagli commented Jun 18, 2024

When plone.volto becomes a distribution, it should ask as part of the site creation form what languages to enable (or at least the primary language), and update the registry setting based on that parameter.

So if you are creating a site with "only" the plone.volto distribution, you can specify the language there, but if you are using plone.volto as a dependency of some other policy package, you can configure the languages in the policy package.

@ericof Do I have it right?

@stevepiercy
Copy link
Contributor

Apologies if this is off-topic. @davisagli's comment brought to my mind to set a default timezone (or enabling multiple timezones) for a site. Should I create a ticket to set the site's default timezone, similar to setting a default language or enabling multiple languages?

@jensens
Copy link
Member Author

jensens commented Jun 19, 2024

When plone.volto becomes a distribution, it should ask as part of the site creation form what languages to enable (or at least the primary language), and update the registry setting based on that parameter.

So if you are creating a site with "only" the plone.volto distribution, you can specify the language there, but if you are using plone.volto as a dependency of some other policy package, you can configure the languages in the policy package.

If the profile here installs already the LRFs for the languages it is a nasty work to remove unneeded. This happened to me, and the reason I wrote this issue.
If it it does not install them, then the distribution install is not complete.

@jensens
Copy link
Member Author

jensens commented Jun 19, 2024

Should I create a ticket to set the site's default timezone, similar to setting a default language or enabling multiple languages?

I would add such a ticket to Products.CMFPlone, because it is not volto-related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants