Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support playwright based robot tests via robotframework-browser extension #149

Merged
merged 8 commits into from
Jul 9, 2023

Conversation

gforcada
Copy link
Member

@gforcada gforcada commented Jun 29, 2023

Big disclaimer: I'm (@gforcada) merely the one that created the PR, the code and credits for this feature, as commits show, goes to @datakurre ✨ 💯

⚠️ It needs the version pins defined on this buildout.coredev branch.

Part of plone/Products.CMFPlone#3813

@mister-roboto
Copy link

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@gforcada
Copy link
Member Author

@jenkins-plone-org please run jobs

@gforcada
Copy link
Member Author

@jenkins-plone-org please run jobs

@datakurre
Copy link
Member

Note about the current version pins:

Until robocorp/robotframework-lsp#947 has been fixed and new robotframework-lsp extension for VSCode released, we must use

robotframework==6.0.2

and robotframework-lsp VSCode extension 1.10.2 to be able to use VSCode integration in collective.recipe.vscode.

Once LSP has been fixed, the latest versions should work again.

@gforcada gforcada force-pushed the datakurre-rfbrowser branch from aba495b to 235ddcb Compare June 30, 2023 16:55
@gforcada
Copy link
Member Author

@jenkins-plone-org please run jobs

@gforcada gforcada merged commit 9c3a0eb into master Jul 9, 2023
@gforcada gforcada deleted the datakurre-rfbrowser branch July 9, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants