Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config with default template #145

Merged
merged 9 commits into from
Oct 19, 2023
Merged

Config with default template #145

merged 9 commits into from
Oct 19, 2023

Conversation

gforcada
Copy link
Member

@gforcada gforcada commented Apr 8, 2023 •
edited
Loading

@datakurre I hope that deleting the buildout configuration is fine, if you can also double check the dependencies it would be great as well ✨

Tests seem to fail locally, not sure if they need more dependencies, or rather more time to run ? 🤔

@mister-roboto
Copy link

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@gforcada gforcada mentioned this pull request Apr 8, 2023
Closed
52 tasks
@gforcada gforcada marked this pull request as draft April 9, 2023 08:03
mauritsvanrees
mauritsvanrees reviewed Apr 14, 2023
View reviewed changes
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem fine.
The failing tests obviously not. I don't have an immediate idea what the cause could be. I have started one Jenkins job.

@gforcada gforcada force-pushed the config-with-default-template-78bb80ce branch from 262eb08 to 254558f Compare June 24, 2023 14:09
@gforcada
Copy link
Member Author

@jenkins-plone-org please run jobs

@gforcada gforcada mentioned this pull request Jun 29, 2023
Draft
@gforcada gforcada force-pushed the config-with-default-template-78bb80ce branch 2 times, most recently from be0b839 to cbb5175 Compare October 14, 2023 22:06
@gforcada gforcada force-pushed the config-with-default-template-78bb80ce branch from cbb5175 to 151dc37 Compare October 15, 2023 16:28
@gforcada gforcada marked this pull request as ready for review October 15, 2023 16:29
@gforcada
Copy link
Member Author

I removed 3 GHA to get this to pass:

  • tests / coverage: somehow they do not run fine on GHA 🤔 but do pass on Jenkins 🤷🏾
  • circular dependencies: there is one such between Products.CMFPlone and plone.app.multilingual ⛓️

Without these actions, the PR should pass fine and thus we can start benefiting from plone/meta DevX 🥳

@gforcada
Copy link
Member Author

@jenkins-plone-org please run jobs

@gforcada gforcada merged commit b99da57 into master Oct 19, 2023
3 checks passed
@gforcada gforcada deleted the config-with-default-template-78bb80ce branch October 19, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensens jensens Awaiting requested review from jensens

@datakurre datakurre Awaiting requested review from datakurre

@mauritsvanrees mauritsvanrees Awaiting requested review from mauritsvanrees

Assignees
No one assigned
Labels
24 status: ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gforcada @mister-roboto @mauritsvanrees @jensens