-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overiding navigation_depth via request param in GlobalSectionsViewlet #301
base: master
Are you sure you want to change the base?
Conversation
@MrTango thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
98af93e
to
10ac403
Compare
@jenkins-plone-org please run jobs |
to be able to pull it via AJAX
…://github.com/plone/plone.app.layout into global_sections_overrideable_navigation_depth
Isn't this missing some zcml to register the new |
we where actually thinking to remove the tempalte here and put it as an example in the docs. |
I would encourage to do that in the |
This is very usefull for mobile navigation