Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overiding navigation_depth via request param in GlobalSectionsViewlet #301

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

MrTango
Copy link
Contributor

@MrTango MrTango commented May 2, 2022

This is very usefull for mobile navigation

@mister-roboto
Copy link

@MrTango thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@MrTango MrTango requested a review from agitator May 2, 2022 17:37
@MrTango MrTango force-pushed the global_sections_overrideable_navigation_depth branch from 98af93e to 10ac403 Compare May 2, 2022 17:38
@agitator
Copy link
Member

agitator commented May 3, 2022

@jenkins-plone-org please run jobs

@mauritsvanrees
Copy link
Member

Isn't this missing some zcml to register the new sections.pt?
Other than that: nice!

@MrTango
Copy link
Contributor Author

MrTango commented May 3, 2022

Isn't this missing some zcml to register the new sections.pt? Other than that: nice!

we where actually thinking to remove the tempalte here and put it as an example in the docs.
So you could use it in your project.
For now the view would not be used in core it self.
But i'm happy either way.
For my current project I'll go i third way and will implement a small js component which will merge the global-sections and the navigation portlet as sub navigation for from level one on. This way i don't have do rerender anything and just copy the html via JS into mobile on demand.

@ale-rt
Copy link
Member

ale-rt commented Jun 29, 2022

I would encourage to do that in the navtree_depth property (that should not be deprecated anymore), see #292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants