-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt styles to Plone 6 #96
base: master
Are you sure you want to change the base?
Conversation
@pbauer thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:
With this simple comment all the jobs will be started automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
@jenkins-plone-org please run jobs |
@jenkins-plone-org please run jobs |
@@ -45,7 +45,7 @@ | |||
class=".diff.DiffView" | |||
name="iterate_diff" | |||
template="diff.pt" | |||
permission="zope2.View" | |||
permission="cmf.ModifyPortalContent" | |||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pbauer I found this old PR while testing plone/Products.CMFPlone#1452. The style updates look good to me. The permission updates also look desirable but I think they will need a bit more work to ensure the rolemap is set up correctly; could you separate out that change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with #120
The rolemap is setup the old-school way in permissiosn.py
Fix #95