Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drafting/Locking of folderish content #50

Open
tomgross opened this issue Aug 11, 2017 · 6 comments
Open

Drafting/Locking of folderish content #50

tomgross opened this issue Aug 11, 2017 · 6 comments

Comments

@tomgross
Copy link
Member

Doing working copies from folderish structures can lead to inconsistent behavior. For a working copy a content item is copied and the original item is locked via WebDAV. If you do this for a folder only the root folder is locked and not the contents of the folder. On both branches editing is possible and when checking in back the edited content is overridden by the old version of the working copy.

This is especially a problem if it is used together with collective.folderishtypes.

Possible solutions of the problem I see:

  1. Remove the folder contents at checkout procedure and put it back from the baseline on checkin (this is currently my favorite)
  2. Don't do a full copy of an object but create a new one and transfer the contents of the schema and annotations
  3. Lock the complete tree
@2silver
Copy link
Contributor

2silver commented Mar 14, 2019

+1 for 1

@tomgross
Copy link
Member Author

@2silver Here is an implementation of 1 which is in production for more than one year, if you are interested: https://github.com/FHNW/plone.app.iterate/tree/tg_norecursive_clean

@2silver
Copy link
Contributor

2silver commented Mar 14, 2019

@2silver Here is an implementation of 1 which is in production for more than one year, if you are interested: https://github.com/FHNW/plone.app.iterate/tree/tg_norecursive_clean

Thank you, saves me a lot of time :-)

@alexsielicki
Copy link

+1 on solution 1

@2silver
Copy link
Contributor

2silver commented Feb 26, 2021

@tomgross are there any plans to integrate your fork into original?
Maybe as optional behavior?

@tomgross
Copy link
Member Author

@2silver I personally don't have any plans, since I currently don't use Plone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants