new behavior: IThumbIconHandling, supress thumbs /icons, adjust thumb… #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgrcon
force-pushed
the
plip1734thumbs
branch
3 times, most recently
from
33faca6
to
8ff9499
Compare
|
You may want to label this yourself as |
16 tasks
fgrcon
force-pushed
the
plip1734thumbs
branch
3 times, most recently
from
db0a80d
to
cf6c078
Compare
fgrcon
force-pushed
the
plip1734thumbs
branch
3 times, most recently
from
4bf5e9d
to
c207823
Compare
jensens
reviewed
Apr 9, 2017
| @@ -1,6 +1,8 @@ | |||
| # -*- coding: utf-8 -*- | |||
| from Acquisition import aq_base | |||
| from Acquisition import aq_inner | |||
| from Products.CMFPlone.interfaces import ISiteSchema | |||
| from Products.CMFPlone.interfaces import ISiteSchema | |||
jensens
reviewed
Apr 9, 2017
| return settings.thumb_size_summary | ||
|
|
||
| def show_icons(self): | ||
| return not getattr(self.context,'suppress_icons',False) |
|
Please check your code with code-analysis. |
… size, templates adapted replaced paper clip icon(fontello) with mime type icons from mimetype registry for file objects plone/Products.CMFPlone#1734
fixed review findings flake8
ebrehault
reviewed
May 31, 2017
| tal:attributes="href item_link; | ||
| class string:$item_type_class $item_wf_state_class url; | ||
| title item_type"> | ||
| <image class="mime-icon" |
There was a problem hiding this comment.
Any reason why we should use image instead of img here? (just curious)
ebrehault
approved these changes
May 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… size, templates adapted
see plone/Products.CMFPlone#1734