Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #54 : "Add item to default page" modal form #55

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

sverbois
Copy link
Contributor

No description provided.

@mister-roboto
Copy link

@sverbois thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@sverbois
Copy link
Contributor Author

@jenkins-plone-org please run jobs

@sverbois
Copy link
Contributor Author

@jenkins-plone-org please run jobs

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the problem exists, and that this PR fixes it. Thanks!

@mauritsvanrees mauritsvanrees merged commit 3cc7261 into master Sep 14, 2023
@mauritsvanrees mauritsvanrees deleted the issue-54 branch September 14, 2023 00:33
@petschki
Copy link
Member

petschki commented Sep 18, 2023

does this need an upgrade step which sets default value to the registry or action options?

@sverbois
Copy link
Contributor Author

sverbois commented Sep 18, 2023

I'm not aware of any link between the "Add item to default page" menu and the configuration register, so I don't think we need an upgrade step.

@mauritsvanrees
Copy link
Member

Indeed no upgrade step needed. This modal option is added on-the-fly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants