Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote version strings in YAML #253

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Quote version strings in YAML #253

merged 1 commit into from
Feb 13, 2018

Conversation

thet
Copy link
Member

@thet thet commented Feb 8, 2018

See: travis-ci/docs-travis-ci-com#1540

Brought to my attention by this PR: collective/icalendar#249

@thet thet requested a review from MrTango February 8, 2018 21:55
mauritsvanrees
mauritsvanrees approved these changes Feb 8, 2018
View reviewed changes
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I guess with 2.7 it does not matter, but if we have Python 3.10 in a couple of years, it would be weird if we suddenly got 3.1 instead. :-)

@jensens jensens merged commit 32cd3e1 into master Feb 13, 2018
@jensens jensens deleted the thet-yamlversionstrings branch February 13, 2018 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

@MrTango MrTango Awaiting requested review from MrTango

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thet @mauritsvanrees @jensens