Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor warnings/info boxes have to be themed #715

Open
djay opened this issue Jul 17, 2015 · 6 comments
Open

editor warnings/info boxes have to be themed #715

djay opened this issue Jul 17, 2015 · 6 comments

Comments

@djay
Copy link
Member

djay commented Jul 17, 2015

user problem

The themers job should be as easy as possible which means once they include the toolbar they don't don't have to theme any other backend internal plone UI, only whats public content.
Currently this warning appears in the content area for only logged in users.

  • "Locked This item was locked by XXXXXX 1 minute ago.
    If you are certain this user has abandoned the object, you may [unlock] the object. You will then be able to edit it."
  • also "Changes Saved"

options

  1. The toolbar shows a lock icon. The themer could just remove the warning from the theme.
  2. Show the warning when the user clicks edit.
    • maybe the edit should get the lock icon since thats the action thats prevented.
  3. Show the warning in the history view since that has the lock icon
  4. Get rid of "changes saved". The last modified date shows this info.

@plone/ux-team feedback?

@vangheem
Copy link
Member

new toolbar will show the lock button fyi. Still shows in the content though.

@djay
Copy link
Member Author

djay commented Jul 17, 2015

yeah the lock icon is great. But I think option 2 of moving the lock icon to edit and having the warning appear when you click on the locked edit is the way to go.

@davilima6
Copy link
Member

+1 for moving lock information next to Edit icon, which would display a tooltip similar to those on Folders Contents navbar containing full lock message: editing user and duration. And if user ignores the tooltip there's the warning prompt anyway.

-1 for omitting from content since it's a nice after load reminder and we're not deprecating portal message: it's needed to show one-time messages for item operations like "Successly copied/cut/pasted items" and many addons also rely on that. It can't be a modal either.

+1 for adopting or implementing a Growl-like notification plugin if we really want to have status messages away from themed domain.

BTW: only Configure, Rearrange and Upload buttons have tooltips on folder contents. For consistency I think all should have. In the same way only content menu based icons have their title set on the toolbar, all should have and I'm also +1 for them to be tooltips.

@djay djay changed the title internal "locked warning" have to be themed editor warnings/info boxes have to be themed Jul 17, 2015
@esteele esteele added this to the Plone 5.0.x milestone Sep 19, 2015
@jcerjak
Copy link
Member

jcerjak commented Sep 21, 2015

Related issue on locking: #1056

@jensens
Copy link
Member

jensens commented Jun 20, 2019

is this still an issue?

@davisagli
Copy link
Member

The lock message is just one example; there are other messages that indicate special content states, such as the one about a plone.app.iterate working copy. I'd suggest a message at the very top or bottom of the window for these to avoid needing to style it to fit inside the content area.

@davisagli davisagli removed this from the Plone 5.0.x milestone Aug 24, 2022
@jensens jensens added this to the Future milestone Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants