Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Swift 3.0 #36

Closed
NinoScript opened this issue Sep 21, 2016 · 8 comments
Closed

Support for Swift 3.0 #36

NinoScript opened this issue Sep 21, 2016 · 8 comments

Comments

@NinoScript
Copy link

Hey, I noticed that you guys are actively adding Swift 3 support for ConsistencyManager-iOS.

Are you planning on adding Swift 3 support for RocketData? Do you need help with that?
Or do you recommend using ConsistencyManager directly?

@plivesey
Copy link
Owner

Definitely adding it to Rocket Data. Hopefully over the next couple of days.

@plivesey
Copy link
Owner

I just pushed to swift3 branch. Probably won't help much to have two people working on it because we'll just step on each other, but thanks for offering.

I'll add you to the PRs if you want to help code review. Like consistency manager, I'll probably do:

  1. First pass to migrate to Swift 3 with no API changes
  2. Second pass to migrate to a better (swift 3) API.

@NinoScript
Copy link
Author

Kudos for doing it like that. I think that was a great idea!

If all libraries had an intermediate step like that, I could've migrated my current projects to Swift 3 without much effort.

@plivesey
Copy link
Owner

#38

@plivesey
Copy link
Owner

Committed. So project should work on Swift3 now.
Going to do a pass on the API to make sure everything has a Swift3 friendly API now.

@plivesey
Copy link
Owner

#39

@plivesey
Copy link
Owner

This is the real change - changing to a swift 3 API :)

@plivesey
Copy link
Owner

plivesey commented Oct 3, 2016

Finished and released!

@plivesey plivesey closed this as completed Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants